Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of _PS_DEBUG_PROFILING_ #11653

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Allow override of _PS_DEBUG_PROFILING_ #11653

merged 1 commit into from
Dec 11, 2018

Conversation

SebBareyre
Copy link
Contributor

@SebBareyre SebBareyre commented Dec 7, 2018 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Allow to override PS_DEBUG_PROFILING constant in defines_custom.inc.php
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Just add define( '_PS_DEBUG_PROFILING_', true ); in defines_custom.inc.php

This change is Reviewable

@SebBareyre
[CO] Allow to override _PS_DEBUG_PROFILING_
0b75cbb 
Allow to override _PS_DEBUG_PROFILING_ constant in defines_custom.inc.php
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Dec 7, 2018
@mickaelandrieu
Copy link
Contributor

Hi @SebBareyre,

in which cases do you want to use the legacy profiler? I'm wondering if we can improve the one available in the migrated pages.

Mickaël

@mickaelandrieu mickaelandrieu changed the title [CO] Allow to override _PS_DEBUG_PROFILING_ Allowed the override of _PS_DEBUG_PROFILING_ Dec 7, 2018
@mickaelandrieu mickaelandrieu added the Waiting for QA Status: action required, waiting for test feedback label Dec 7, 2018
@SebBareyre
Copy link
Contributor Author

Hi @mickaelandrieu

I need to use it on front office.
By the way, there is a problem on the profiling tool : #9659

Seb

@ntiepresta ntiepresta assigned ntiepresta and unassigned ntiepresta Dec 10, 2018
@ntiepresta ntiepresta added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 10, 2018
@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Dec 11, 2018
@Quetzacoalt91 Quetzacoalt91 merged commit 1ce076c into PrestaShop:develop Dec 11, 2018
@Quetzacoalt91
Copy link
Member

Thank you @SebBareyre

@eternoendless eternoendless changed the title Allowed the override of _PS_DEBUG_PROFILING_ Allow override of _PS_DEBUG_PROFILING_ Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelandrieu mickaelandrieu mickaelandrieu approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SebBareyre @mickaelandrieu @Quetzacoalt91 @prestonBot @ntiepresta